Parameterize key query fields in riem_measures() #48
Conversation
…t values for station, date_start args (thus making them required); Convert elev and latlon to logicals; Update DESCRIPTION and documentation
|
Ready for review, pending my outstanding question on default value for |
|
I'm unsure what your standard practice is, but I'll leave it to you to click "Resolve conversation" on any items resolved to your liking. Thanks! |
|
@JElchison Thank you!! I made a few changes
I have two requests for you:
Afterwards I'll update the NEWS file and will plan a new release in January. Thanks again! |
Yes, they look good! I asked a couple clarifying questions as comments.
Yes, will do! |
tests/testthat/test-measures.R
Outdated
| date_end = "2013-12-01")) | ||
| }) | ||
|
|
||
| # TODO validate 'data' against [all, tmpf, dwpf, relh, drct, sknt, p01i, alti, mslp, vsby, gust, skyc1, skyc2, skyc3, skyc4, skyl1, skyl2, skyl3, skyl4, wxcodes, ice_accretion_1hr, ice_accretion_3hr, ice_accretion_6hr, peak_wind_gust, peak_wind_drct, peak_wind_time, feel, metar, snowdepth] # nolint: line_length_linter |
There was a problem hiding this comment.
should we tackle this in this PR?
|
@JElchison Thank you! Are you happy with my own changes to the checks on the data arguments? I'll come back to this PR in the new year, merge it and work on a release (I might also tackle the other breaking change at the same time). Thank you and happy holidays! |
Expose key query fields in
riem_measures()as parameters, including:data(defaults toallas before)elev(defaults tonoas before)latlon(defaults toyesas before)report_type(new default is3,4, which skips HFMETAR)Update
date_startto have safer default (2024 instead of 2014). Specify missingnometaquery field. Update comments, self-documentation, and lintr exceptions accordingly.